-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏃 Update golangci-lint to 1.47.3 #1976
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It looks like some files where violating the lint |
Seems the latest version wants to gofmt in the (incompatible) go 1.19 style, I went back one version to not have go 1.19 support as the repo is tested with go 1.18, lets see how that goes |
The error assertions in the dynamic rest mappers checkAndReload never worked and fixing them makes the tests fail :/ |
What do you mean? The old code looked fine to me after inspection. |
/lgtm |
I think this is fine, as can be seen by the prior failures this has a very good test coverage |
Updates golangci-lint in github actions